Handle error on Address not found #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use a wallet address which does not exist, it gives the following error: ``` Error: empty address string is not allowed ``` which is coming from the SDK and confusing to the user. The reason is because one error is not handled properly, in the new proposal, the error is handled which returns the following error if the address does not exist: ``` Error: The specified item could not be found in the keyring ```
ethanfrey
approved these changes
Oct 21, 2021
| @@ -57,6 +57,9 @@ func StoreCodeCmd() *cobra.Command { | |||
| Args: cobra.ExactArgs(1), | |||
| RunE: func(cmd *cobra.Command, args []string) error { | |||
| clientCtx, err := client.GetClientTxContext(cmd) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Looks like something a linter should have caught.
There was a problem hiding this comment.
yes, this was caught by the linter. I marked this and other commands in #645.
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 60.24% 60.18% -0.07%
==========================================
Files 48 48
Lines 5313 5315 +2
==========================================
- Hits 3201 3199 -2
- Misses 1888 1891 +3
- Partials 224 225 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use a wallet address which does not exist, it gives the following error:
which is coming from the SDK and confusing to the user.
The reason is because one error is not handled properly, in the new proposal, the error is handled which returns the following error if the address does not exist: