Limit simulation gas #674
Merged
Limit simulation gas #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
+ Coverage 60.22% 60.24% +0.02%
==========================================
Files 48 48
Lines 5340 5361 +21
==========================================
+ Hits 3216 3230 +14
- Misses 1896 1902 +6
- Partials 228 229 +1
|
ethanfrey
approved these changes
Nov 17, 2021
| return next(ctx, tx, simulate) | ||
| } | ||
|
|
||
| // apply custom node gas limit |
There was a problem hiding this comment.
Looks good. Maybe this could be "simplified"? But fine as is.
if d.gasLimit != nil {
ctx = ctx.WithGasMeter(sdk.NewGasMeter(*d.gasLimit))
} else if maxGas := ctx.ConsensusParams().GetBlock().MaxGas; maxGas > 0 {
ctx = ctx.WithGasMeter(sdk.NewGasMeter(sdk.Gas(maxGas)))
}
return next(ctx, tx, simulate)| @@ -107,3 +111,77 @@ func TestCountTxDecorator(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
| func TestLimitSimulationGasDecorator(t *testing.T) { | |||
maurolacy
reviewed
Nov 19, 2021
| // SimulationGasLimit is the max gas to be used in a tx simulation call. | ||
| // When not set the consensus max block gas is used instead | ||
| SimulationGasLimit *uint64 | ||
| // SimulationGasLimit is the max gas to be used in a smart query contract call |
There was a problem hiding this comment.
Just taking a look at this. You mean, SmartQueryGasLimit.
faddat
pushed a commit
to notional-labs/wasmd
that referenced
this pull request
Nov 25, 2021
* Limit simulation gas * Put parameters on separate lines
faddat
pushed a commit
to notional-labs/wasmd
that referenced
this pull request
Nov 27, 2021
* Limit simulation gas * Put parameters on separate lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #670
Adds a new startup param/config and ante handler to limit gas for simulations: