Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.17 provides a much clearer go.mod file #679

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 23, 2021

No description provided.

@faddat faddat requested a review from alpe as a code owner November 23, 2021 09:47
@alpe
Copy link
Contributor

alpe commented Nov 23, 2021

Thanks for the PR and little push to move to v1.17.
Meanwhile gaiad and sdk are on v1.17 so let's do it as well. There are some other places like .circleci/config and the Dockerfile that would need the upgrade as well. Would you upgrade them as well?

@faddat
Copy link
Contributor Author

faddat commented Nov 23, 2021

Happy to make those changes :)

@faddat
Copy link
Contributor Author

faddat commented Nov 24, 2021

Pretty sure that the remaining error is an issue on your build machine.

@alpe
Copy link
Contributor

alpe commented Nov 24, 2021

Very nice. Thanks for the contribution 💐
Benchmark tests are flickering indeed. It is on my list. Sorry for the inconvenience.

@alpe alpe merged commit 1da2078 into CosmWasm:master Nov 24, 2021
faddat added a commit to notional-labs/wasmd that referenced this pull request Nov 27, 2021
* Go 1.17 provides a much clearer go.mod file

* tidy

* Go 1.17 cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants