Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasmwm version #748

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Update wasmwm version #748

merged 1 commit into from
Feb 10, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Feb 9, 2022

Resolves #747

@pinosu pinosu requested a review from alpe as a code owner February 9, 2022 12:26
@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #748 (f947b15) into master (f4afc18) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   58.47%   58.51%   +0.03%     
==========================================
  Files          49       49              
  Lines        5828     5828              
==========================================
+ Hits         3408     3410       +2     
+ Misses       2170     2169       -1     
+ Partials      250      249       -1
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.90% <0.00%> (+0.35%) ⬆️

ethanfrey
ethanfrey approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

did you manually test docker build? (always good to do once for such upgrades)

@pinosu
Copy link
Contributor Author

pinosu commented Feb 10, 2022

Yes, it builds without errors.

@pinosu pinosu merged commit 33d768c into master Feb 10, 2022
@alpe alpe deleted the 747-update_wasmwm branch May 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@alpe alpe Awaiting requested review from alpe

@maurolacy maurolacy Awaiting requested review from maurolacy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wasmvm to 1.0.0-beta6
2 participants
@pinosu @ethanfrey