Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove io/ioutil #934

Merged
merged 2 commits into from
Aug 24, 2022
Merged

remove io/ioutil #934

merged 2 commits into from
Aug 24, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 9, 2022

ioutil was deprecated in go 1.16 and is an error in go 1.19

@faddat faddat requested a review from alpe as a code owner August 9, 2022 15:45
@faddat faddat changed the title depracte-ioutil remove io/ioutil Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #934 (03fda0d) into main (f14c469) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   59.26%   59.23%   -0.04%     
==========================================
  Files          51       51              
  Lines        6206     6206              
==========================================
- Hits         3678     3676       -2     
- Misses       2262     2263       +1     
- Partials      266      267       +1     
Impacted Files Coverage Δ
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/client/cli/tx.go 25.00% <100.00%> (ø)
x/wasm/keeper/keeper.go 88.27% <0.00%> (-0.34%) ⬇️

@faddat
Copy link
Contributor Author

faddat commented Aug 13, 2022

this is also ready to go.

@ethanfrey ethanfrey added this to the v0.29.0 milestone Aug 15, 2022
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you for doing the 🧹. 💪

@alpe alpe merged commit 4875db2 into CosmWasm:main Aug 24, 2022
@faddat faddat mentioned this pull request Oct 2, 2022
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants