-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmd v0.29.2 and SDK v0.46.6 and IBC v5.1.0 #938
Conversation
This reverts commit e637cf5.
@vuong177 I checked, and the commit that we're using here, is up to date with the latest commit from ibc-go, so it might not be that.... |
yep, seem have problem with router |
Great progress! |
THis commit hash b385d2d corresponds to the last known fully good happy version, and it also corresponds to v0.29.1 |
adding instantiate-anyof-addresses flag in the gov_tx.go (cherry picked from commit b7e4770)
NB: this is v0.29.2 + needed adaptations for 46 this commit: is working nicely. This patch may require this: https://twitter.com/gadikian/status/1592157214600749057 cosmos/interchain-accounts-demo#152 or be subject to occasional bech32 wierdnesses. |
@faddat nice job. is there any timeline for merging this? |
Hey, @MSNTCS I think that the wasmd team will be merging work based on sdk v0.47.*, not this. I must also mention this: This branch has really been a moving target. I think the above change will require updates to ibc-go also. |
Important Notes on SDK v0.47.x work and information on how we see items like this branch: |
Kudos, SonarCloud Quality Gate passed! |
You have 2 branches open for SDK v0.46. Can this be closed in favour of #1126? Or the other way? |
Yeah, I think that makes sense. No one building, should make a chain with this one. Thanks! |
Funded by Juno, built by Notional
wasmd for the SDK 46 series:
NOTICE
Some somewhat conflicting information about the status of cosmos-sdk v0.46.* was released on the cosmos hub forum, here:
https://forum.cosmos.network/t/ibc-security-advisory-dragonberry/7702
Later discussions with the SDK team and Umee revealed that a patch was underway. Notional will continue to maintain this branch so that users of sdk 46 are able to work with security.
Given that this branch has active users that want to make chain happen, we're going to try to restore it to its former glory, specifically, it should pass 100% of the tests.
I am iffy on all of this, but it ought to be 1-3 days work to ensure that this branch works again. When it passes all tests, I will remove the below warning. Notional will continue to work on SDK v47 support for:
Guidance
THis commit hash b385d2d
corresponds to the last known fully good happy version, and it also corresponds to v0.29.1 in main.
Funded by Juno built by Notional