Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes in protogen script #956

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Revert changes in protogen script #956

merged 3 commits into from
Aug 24, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 24, 2022

Follow up on #866 (comment)

Bump proto-gen container to the version used by the SDK v0.45.x

@alpe alpe changed the title Fix proto gen Revert changes in protogen script Aug 24, 2022
@alpe alpe requested a review from pinosu August 24, 2022 09:56
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #956 (7da9b4a) into main (61bda97) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   59.37%   59.34%   -0.04%     
==========================================
  Files          51       51              
  Lines        6218     6218              
==========================================
- Hits         3692     3690       -2     
- Misses       2261     2262       +1     
- Partials      265      266       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 88.33% <0.00%> (-0.34%) ⬇️

@@ -165,7 +165,7 @@ format: format-tools
###############################################################################
### Protobuf ###
###############################################################################
PROTO_BUILDER_IMAGE=tendermintdev/sdk-proto-gen@sha256:372dce7be2f465123e26459973ca798fc489ff2c75aeecd814c0ca8ced24faca
PROTO_BUILDER_IMAGE=tendermintdev/sdk-proto-gen:v0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit c993eef into main Aug 24, 2022
@alpe alpe deleted the fix_proto-gen branch August 24, 2022 12:29
@faddat faddat mentioned this pull request Oct 2, 2022
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* Revert protocgen changes from CosmWasm#866

* Go mod tidy

* Bump proto-gen image one version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants