-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ugrade sdk to v0.45.7 #959
Conversation
This reverts commit e637cf5.
nice! This will help with database performance, thank you! @alpe , what's the reasoning behind not upgrading ibc-go? |
@@ -343,6 +345,7 @@ func SignAndDeliver( | |||
chainID string, accNums, accSeqs []uint64, expSimPass, expPass bool, priv ...cryptotypes.PrivKey, | |||
) (sdk.GasInfo, *sdk.Result, error) { | |||
tx, err := helpers.GenTx( | |||
rand.New(rand.NewSource(time.Now().UnixNano())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -159,7 +161,8 @@ func InitializeWasmApp(b testing.TB, db dbm.DB, numAccounts int) AppInfo { | |||
Msg: initBz, | |||
} | |||
gasWanted := 500000 + 10000*uint64(numAccounts) | |||
initTx, err := helpers.GenTx(txGen, []sdk.Msg{&initMsg}, nil, gasWanted, "", []uint64{0}, []uint64{1}, minter) | |||
initTx, err := helpers.GenTx(rand.New(rand.NewSource(time.Now().UnixNano())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 59.37% 59.31% -0.07%
==========================================
Files 51 51
Lines 6218 6221 +3
==========================================
- Hits 3692 3690 -2
- Misses 2261 2265 +4
- Partials 265 266 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
* 457 * upgrade ci * go get -> go install * change denom to new format * Update config.yml * Revert "change denom to new format" This reverts commit e637cf5. * bump ibc-go to v3.2.x * Update config.yml * ibc-go v3.2.0 * Revert ibc-go version upgrade Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
This is the same as #937 without ibc-go upgrade. All credits go to @faddat ❤️