Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugrade sdk to v0.45.7 #959

Merged
merged 11 commits into from
Aug 25, 2022
Merged

Ugrade sdk to v0.45.7 #959

merged 11 commits into from
Aug 25, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 25, 2022

This is the same as #937 without ibc-go upgrade. All credits go to @faddat ❤️

@alpe alpe requested a review from pinosu August 25, 2022 08:30
@faddat
Copy link
Contributor

faddat commented Aug 25, 2022

nice! This will help with database performance, thank you!

@alpe , what's the reasoning behind not upgrading ibc-go?

@@ -343,6 +345,7 @@ func SignAndDeliver(
chainID string, accNums, accSeqs []uint64, expSimPass, expPass bool, priv ...cryptotypes.PrivKey,
) (sdk.GasInfo, *sdk.Result, error) {
tx, err := helpers.GenTx(
rand.New(rand.NewSource(time.Now().UnixNano())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -159,7 +161,8 @@ func InitializeWasmApp(b testing.TB, db dbm.DB, numAccounts int) AppInfo {
Msg: initBz,
}
gasWanted := 500000 + 10000*uint64(numAccounts)
initTx, err := helpers.GenTx(txGen, []sdk.Msg{&initMsg}, nil, gasWanted, "", []uint64{0}, []uint64{1}, minter)
initTx, err := helpers.GenTx(rand.New(rand.NewSource(time.Now().UnixNano())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #959 (5f76df0) into main (c993eef) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   59.37%   59.31%   -0.07%     
==========================================
  Files          51       51              
  Lines        6218     6221       +3     
==========================================
- Hits         3692     3690       -2     
- Misses       2261     2265       +4     
- Partials      265      266       +1     
Impacted Files Coverage Δ
app/test_helpers.go 0.82% <0.00%> (-0.02%) ⬇️
x/wasm/keeper/keeper.go 88.33% <0.00%> (-0.34%) ⬇️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@alpe alpe merged commit 60da5c0 into main Aug 25, 2022
@alpe alpe deleted the sdk-upgrade0457 branch August 25, 2022 08:52
@faddat faddat mentioned this pull request Oct 2, 2022
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* 457

* upgrade ci

* go get -> go install

* change denom to new format

* Update config.yml

* Revert "change denom to new format"

This reverts commit e637cf5.

* bump ibc-go to v3.2.x

* Update config.yml

* ibc-go v3.2.0

* Revert ibc-go version upgrade

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants