Skip to content

Fix builders #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

Fix builders #623

merged 3 commits into from
Feb 13, 2025

Conversation

@chipshort
Copy link
Contributor

@chipshort chipshort commented Feb 13, 2025

After updating in #621, the alpine builder was failing. This fixes the builders.

I'll release when this gets approved.

webmaster128
webmaster128 reviewed Feb 13, 2025
View reviewed changes
webmaster128
webmaster128 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am not horribly familiar with the env variables and how they need to be set

@chipshort chipshort merged commit f5e645f into main Feb 13, 2025
15 checks passed
@chipshort chipshort deleted the co/fix-builders branch February 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

@aumetra aumetra Awaiting requested review from aumetra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chipshort @webmaster128