Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextView could auto-adjust hight based on text lines #1127

Closed
kolczak opened this issue Aug 2, 2018 · 4 comments
Closed

TextView could auto-adjust hight based on text lines #1127

kolczak opened this issue Aug 2, 2018 · 4 comments
Assignees
@daniel-jonathan @OrkhanAlikhanov
Labels
feature request investigate material

Comments

@kolczak
Copy link

kolczak commented Aug 2, 2018

Hi,
did you think about enhancing the TextView to automatically adjust its height to display all the text it contains? It could expand its hight while user typing.
Regards!
@OrkhanAlikhanov
Copy link
Contributor

I think if you disable isScrollEnabled and set relevant constraints, it will behave like that.

@daniel-jonathan
Copy link
Member

@OrkhanAlikhanov Let's confirm this. If not, I agree that we should support it.

@OrkhanAlikhanov
Copy link
Contributor

@DanielDahan By disabling isScrollEnabled we lose ability to scroll. I think we can introduce preferredMaxLayoutHeight, allow growing upto that point and scroll after.

@OrkhanAlikhanov OrkhanAlikhanov mentioned this issue Aug 7, 2018
Merged
@daniel-jonathan
Copy link
Member

This issue has been addressed in this PR #1130

@daniel-jonathan daniel-jonathan mentioned this issue Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

@OrkhanAlikhanov OrkhanAlikhanov

Labels
feature request investigate material
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kolczak @daniel-jonathan @OrkhanAlikhanov