Addressed multiple issues #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielDahan You can now close #834 in favor of new Editor component added in this PR. |
This was referenced Aug 8, 2018
|
Nice, I am going to test this through |
|
Hi @DanielDahan when is this text view multi-line support going to be released? |
|
@Yash2711 We are in the middle of preparing a release for Sunday night, to Monday morning. This will be included. |
|
Excellent. Thank you so much @DanielDahan |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Editorcomponent. TextView with animated placeholder #1125TextView.preferredMaxLayoutHeight. TextView could auto-adjust hight based on text lines #1127textInset: CGFloatand addedtextInsets: EdgeInsetstoTextFieldTextField.placeholderLabelTextField animates weird when text alignment is .right and we have textInset #1128Editor component with growing enabled:
@DanielDahan It would be easy to review commit by commit rather than whole changes at once.