Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Later versions (2.12.1 and above) - Navigation Bar/Items don't show in iOS 10 and below #924

Closed
st34m3dr1c3 opened this issue Oct 20, 2017 · 12 comments

Comments

@st34m3dr1c3
Copy link

st34m3dr1c3 commented Oct 20, 2017

Compiling with 2.12.1 and above seems to make the Material custom Navigation Bar and its Items show as blank white space in any iOS below 11.

Deploying on iOS 11 and above seems to fix the issue.

Any advice on fixing this? Probably something small I'm missing.

@st34m3dr1c3
Copy link
Author

st34m3dr1c3 commented Oct 20, 2017

Note that this applies to the Github manual install. I am not using cocoapods. Also, compiler is now in Swift 4, so that might be the reason.

Reverting back to version 2.10.2 seems to fix issue on both iOS 10 and 11.

@daniel-jonathan
Copy link
Member

I am downloading the iOS 10 simulator and will check to see what the issue is. I will update you shortly. Thank you!

@daniel-jonathan
Copy link
Member

Hey! I tried this on iOS 10.3.1 and all seems to look good.

screen shot 2017-10-22 at 1 48 43 pm

Anything I am missing, or can you send over a sample project please ?

@st34m3dr1c3
Copy link
Author

st34m3dr1c3 commented Oct 22, 2017 via email

@daniel-jonathan
Copy link
Member

I will take a look today :)

@daniel-jonathan
Copy link
Member

@st34m3dr1c3 I confirmed the issue. I am working on a solution. Thank you for sharing this :)

@st34m3dr1c3
Copy link
Author

st34m3dr1c3 commented Oct 25, 2017 via email

@daniel-jonathan
Copy link
Member

I fixed it :) I will push to the development branch and would you be able to confirm?

@st34m3dr1c3
Copy link
Author

st34m3dr1c3 commented Oct 26, 2017 via email

@daniel-jonathan
Copy link
Member

There is an issue I found with iOS 11 and sizing not behaving correctly. I will be fixing that with this fix as well.

@daniel-jonathan
Copy link
Member

You can find this fixed in Material 2.12.12. Thank you!

@Shempaiii
Copy link

Hey guys i fix this by adding this block of code after setting the Navigation Title:

self.navigationController?.navigationBar.setNeedsLayout()
self.navigationController?.navigationBar.layoutIfNeeded()
self.navigationController?.navigationBar.setNeedsDisplay()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants