-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Later versions (2.12.1 and above) - Navigation Bar/Items don't show in iOS 10 and below #924
Comments
Note that this applies to the Github manual install. I am not using cocoapods. Also, compiler is now in Swift 4, so that might be the reason. Reverting back to version 2.10.2 seems to fix issue on both iOS 10 and 11. |
I am downloading the iOS 10 simulator and will check to see what the issue is. I will update you shortly. Thank you! |
Hi Daniel,
Thanks for testing! I seem to find issues running even with your sample
project (try the storyboard sample from your Samples repository for
Navigation Controller).
Granted, I was deploying on real iOS devices and not on a simulator. If I
sourced the project to Material 2.12 and above, the navigation bar would
simply disappear. Sourcing back to Material 2.10 (as used in the Pods file
for the sample project) seemed to fix the issue.
Do you happen to have an iOS device that you could test on? It seems very
reproducible there.
Thanks again!
…On Sun, Oct 22, 2017 at 7:49 PM, Daniel Dahan ***@***.***> wrote:
Hey! I tried this on iOS 10.3.1 and all seems to look good.
[image: screen shot 2017-10-22 at 1 48 43 pm]
<https://user-images.githubusercontent.com/9982123/31865675-d086d8be-b72f-11e7-874b-da0f83f5376f.png>
Anything I am missing, or can you send over a sample project please ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#924 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUEggagij7uYWLteArGWradwjUb52PSrks5su5xjgaJpZM4QAL9a>
.
|
I will take a look today :) |
@st34m3dr1c3 I confirmed the issue. I am working on a solution. Thank you for sharing this :) |
Thanks!
Also, I might add that in 2.10 the navigation bar is slightly offset to the
right by default.
See screenshot for details.
Cheers!
…On Thu, Oct 26, 2017 at 1:51 AM Daniel Dahan ***@***.***> wrote:
@st34m3dr1c3 <https://github.com/st34m3dr1c3> I confirmed the issue. I am
working on a solution. Thank you for sharing this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#924 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUEggWzktSnhUGBdqr1N1EZmwE_56j7qks5sv8l6gaJpZM4QAL9a>
.
|
I fixed it :) I will push to the development branch and would you be able to confirm? |
Yes, but I wont have a chance to test it on an iOS10 device until next
week. I will do so then and get back to you.
Thanks again!
…On Thu, Oct 26, 2017 at 2:04 AM Daniel Dahan ***@***.***> wrote:
I fixed it :) I will push to the development branch and would you be able
to confirm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#924 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUEggdH8TREzYoXGCZZWk3rk2AwbSi98ks5sv8yfgaJpZM4QAL9a>
.
|
There is an issue I found with iOS 11 and sizing not behaving correctly. I will be fixing that with this fix as well. |
You can find this fixed in Material 2.12.12. Thank you! |
Hey guys i fix this by adding this block of code after setting the Navigation Title: self.navigationController?.navigationBar.setNeedsLayout() |
Compiling with 2.12.1 and above seems to make the Material custom Navigation Bar and its Items show as blank white space in any iOS below 11.
Deploying on iOS 11 and above seems to fix the issue.
Any advice on fixing this? Probably something small I'm missing.
The text was updated successfully, but these errors were encountered: