Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Line on TabBar on bottom of scrollView on X #945

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Align Line on TabBar on bottom of scrollView on X #945

merged 1 commit into from
Oct 29, 2017

Conversation

MattKiazyk
Copy link
Contributor

Using the TabsController Sample, if you add a line with and alignment of bottom, since the changes on Material 2.12.10 on iPhoneX, the line does not show up.

class AppTabsController: TabsController {
    open override func prepare() {
        super.prepare()
                tabBarAlignment = .bottom
                tabBar.tabBarStyle = .auto
                tabBar.dividerColor = nil
                tabBar.lineHeight = 5.0
                tabBar.lineAlignment = .bottom
                tabBar.lineColor = UIColor.blue
                tabBar.backgroundColor = Color.white
    }
}

screenshot 2017-10-28 21 29 35

If you look at the debugger the line is actually shown in the unsafe area at the bottom of X
screenshot 2017-10-28 21 28 19

This PR fixes the issue by putting line at the bottom of the scrollView, not the bounds of the TabBar.

screenshot 2017-10-28 22 19 00

@daniel-jonathan daniel-jonathan changed the base branch from master to development October 29, 2017 17:31
@daniel-jonathan daniel-jonathan self-assigned this Oct 29, 2017
@daniel-jonathan daniel-jonathan merged commit 68d0e14 into CosmicMind:development Oct 29, 2017
@daniel-jonathan
Copy link
Member

You can find this merge in Material 2.12.12. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants