Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Page Issue Fixed, Readme Update #44

Merged
merged 2 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,65 @@

Thank you for help improving LiSA. All kinds of contributions are welcome. We are open to suggestions!

Please submit an Issue or even better a PR and We'll review :)
Please submit an Issue or even better a PR and We'll review :)

## 📖 Installation

### Building From Source

- Clone the project using

```cli
git clone https://github.com/Cosmicoppai/LiSA.git
```

#### Prerequisites

- Make sure python 3.10 and node 18 are installed.

#### Installing

1. Create and activate the virtual environment

```cli
python -m venv ./env
env/Script/activate
```

2. Install the dependencies using the `requirements.txt` and `build_requirements.txt` files.

```cli
pip install -r ./requirements.txt
pip install -r ./build_requirements.txt
```

3. Create `.env` & paste the following content

```dotenv
REACT_APP_SERVER_URL=http://localhost:6969
REACT_APP_SOCKET_URL=ws://localhost:9000
```

4. Install Node modules

```
npm install
```

5. Add `ffmpeg` executable to `root folder` or in `PATH` Var.

6. Build package using

```cli
npm run build:package:windows
```

Note:

> Make sure to allow app to run as admin and allow incomming port forwarding on (`6969`, `9000`).

<br>

### Environment Tested on

- Tested on Windows 8, 10 & 11.
65 changes: 1 addition & 64 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,69 +63,6 @@

Download the [latest release](https://github.com/Cosmicoppai/LiSA/releases) from here and extract the zip file.

## 📖 Installation

### Building From Source

- Clone the project using

```cli
git clone https://github.com/Cosmicoppai/LiSA.git
```

#### Prerequisites

- Make sure python 3.10 and node 18 are installed.

#### Installing

1. Create and activate the virtual environment

```cli
python -m venv ./env
env/Script/activate
```

2. Install the dependencies using the `requirements.txt` and `build_requirements.txt` files.

```cli
pip install -r ./requirements.txt
pip install -r ./build_requirements.txt
```

3. Create `.env` & paste the following content

```dotenv
REACT_APP_SERVER_URL=http://localhost:6969
REACT_APP_SOCKET_URL=ws://localhost:9000
```

4. Install Node modules

```
npm install
```

5. Add `ffmpeg` executable to `root folder` or in `PATH` Var.

6. Build package using

```cli
npm run build:package:windows
```

Note:

> Make sure to allow app to run as admin and allow incomming port forwarding on (`6969`, `9000`).

<br>

### Environment Tested on

- Tested on Windows 8, 10 & 11.

<br>

## 😁 Demo

### Screenshots
Expand Down Expand Up @@ -223,7 +160,7 @@ Download and Install VLC Media player form [here](https://www.videolan.org/vlc/d

## 🤝 CONTRIBUTING

Contributions, issues, and feature requests are welcome! See [CONTRIBUTING.md](./contributing.md)
Contributions, issues, and feature requests are welcome! See [Check Contribution Guide.](./contributing.md)

## ⭐ SUPPORT

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@
"author": "",
"description": "",
"private": true,
"homepage": "https://github.com/Cosmicoppai/LiSA",
"homepage": "./",
"main": "main.js",
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/Cosmicoppai/LiSA"
},
"browserslist": {
"production": [
">0.2%",
Expand Down
6 changes: 3 additions & 3 deletions src/components/paginateCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default function PaginateCard({

if (!loading && ep_details) {
let current_page_eps = ep_details.ep_details;
current_page_eps.map((single_ep, idx) => {
current_page_eps?.map((single_ep, idx) => {
if (Object.keys(single_ep)[0] == currentEp) {
coloredIdx = idx;
}
Expand Down Expand Up @@ -142,7 +142,7 @@ export default function PaginateCard({
<Box mt={5}>
{!loading && ep_details ? (
<Flex direction={"row"} flexWrap="wrap" width={"100%"} justifyContent="center">
{ep_details?.ep_details.map((item, key) => {
{ep_details?.ep_details?.map((item, key) => {
return (
<Flex
cursor={"pointer"}
Expand Down Expand Up @@ -243,7 +243,7 @@ export default function PaginateCard({
</MenuButton>
<MenuList>
<MenuGroup title="Select quality">
{qualityOptions.map(({ id, height }) => {
{qualityOptions?.map(({ id, height }) => {
return (
<MenuItem
onClick={() => singleDownloadHandler(id)}
Expand Down
2 changes: 1 addition & 1 deletion src/screens/settingScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function SettingScreen() {
style={{
cursor: 'pointer'
}}
onClick={() => shell.openExternal(pkg.homepage)}
onClick={() => shell.openExternal(pkg.repository.url)}
>
<Icon
as={RxGithubLogo}
Expand Down