remove permission read security from viewer #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neomatamune
requested changes
Nov 12, 2024
Member
neomatamune
left a comment
neomatamune
left a comment
There was a problem hiding this comment.
Ensure that change does not break cosmotech-api code before merging
and what of COMMON_ROLE_READER_PERMISSIONS ?
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
20515a7 to
fea1331
Compare
removed permission to read security from the rbac role viewer
Leopold-Cramer
force-pushed
the
LCRA/change_security_visibility_per_role_PROD-14053
branch
from
fea1331 to
0cdaa9c
Compare
jreynard-code
approved these changes
Dec 10, 2024
Member
jreynard-code
left a comment
jreynard-code
left a comment
There was a problem hiding this comment.
LGTM. do not forget to backport that change on branch release/3.2 too
jreynard-code
deleted the
LCRA/change_security_visibility_per_role_PROD-14053
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed permission to read security from the rbac role viewer