Skip to content

Conversation

@sjoubert
Copy link
Contributor

No description provided.

sjoubert added 3 commits March 6, 2025 10:45
- csm.platform.{summary,description,version} are not used
- csm.platform.{commitId,vcsRef} should not be configurable at runtime,
  we'll inject them at build time from the build system
Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sjoubert sjoubert merged commit d794f3f into main Mar 10, 2025
5 checks passed
@sjoubert sjoubert deleted the provide_version branch March 10, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants