Skip to content

Conversation

@icreated
Copy link
Contributor

@icreated icreated commented Feb 27, 2023

Connectors findAll can be represented like this:

  override fun findAllConnectors(page: Int?, size: Int?): List<Connector> {
    val maxResult = csmPlatformProperties.twincache.connector.maxResult
    var pageRequest = constructPageRequest(page, size, maxResult)
    if (pageRequest != null) {
      return connectorRepository.findAll(pageRequest).toList()
    }
    return findAllPaginated(maxResult) { connectorRepository.findAll(it).toList() }
  }

Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)
Just a little change and everything is fine ;)

Copy link
Contributor Author

@icreated icreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok

Copy link
Member

@jreynard-code jreynard-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@icreated icreated merged commit 75c4a2f into main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants