Fix JWT token Cast + Handle Custom admin role in CsmAdmin verification #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icreated
reviewed
May 16, 2023
|
|
||
| if (authentication is JwtAuthenticationToken) { | ||
| return authentication.token.tokenValue.let { | ||
| JWTParser.parse(it).jwtClaimsSet.getStringClaim(configuration.authorization.mailJwtClaim) |
Contributor
There was a problem hiding this comment.
This line is present 2 times :
JWTParser.parse(it).jwtClaimsSet.getStringClaim(configuration.authorization.mailJwtClaim)
To refactor? Maybe with when
Member
Author
There was a problem hiding this comment.
Good point, will change it (certainly) use when syntax when we'll integrate Keycloak as identity provider ;)
|
|
||
| if (authentication is JwtAuthenticationToken) { | ||
| return authentication.token.tokenValue.let { | ||
| JWTParser.parse(it).jwtClaimsSet.getStringListClaim(configuration.authorization.rolesJwtClaim) |
Contributor
There was a problem hiding this comment.
The same, like before, line 2 times: JWTParser.parse(it).jwtClaimsSet.getStringListClaim(configuration.authorization.rolesJwtClaim)
Member
Author
There was a problem hiding this comment.
Good point, will change it (certainly) use when syntax when we'll integrate Keycloak as identity provider ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.