Manually removed failing deprecated tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually fix the generated code to test the remaining workflow.
sjoubert
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually removed some failing tests. These are left-overs from previous versions of the cosmotech-api but in the current state our CI/CD does not seem to remove deleted files, but adds the new ones.
A better solution will be to fix the source of the problem in the cosmotech-api repository (https://cosmo-tech.atlassian.net/browse/PROD-14252). However, it is still worth manually removing these failing tests for now so we can have a workflow that is successful if we fixed the other problems in our python-client generation and also to get notified if new problems arise.