Skip to content

feat: collapsable compounds, react switch, lib bug #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: collapsable compounds, react switch, lib bug #221

wants to merge 1 commit into from

Conversation

OskarHowe
Copy link

@OskarHowe OskarHowe commented Aug 11, 2022 •
edited
Loading

  • import of cytoscape-expand-collapse package
  • collapseExpand API, Cytoscape stord as refs
  • new Switch (MUI) to collapse/ expand clusters
  • new event: right click on collapsed compound to expand it
  • new default label for the switch component

Attention:

  • used lib has a bug when changing the layout in combination with clustered nodes: Issue
  • Furthermore the Expand-Collapse library has a bug which causes the canvas to extend unintentionally, when the canvas is embedded in a flex element Issue

@OskarHowe OskarHowe requested a review from csm-thu August 12, 2022 07:53
@OskarHowe OskarHowe force-pushed the OHOW/collapsable_compounds branch 2 times, most recently from 1c6a520 to cb82970 Compare August 12, 2022 14:02
@OskarHowe OskarHowe force-pushed the OHOW/collapsable_compounds branch from cb82970 to 6dfdf94 Compare August 18, 2022 13:48
csm-thu
csm-thu requested changes Aug 18, 2022
View reviewed changes
src/charts/CytoViz/CytoViz.js
<div className={classes.settingLine}>
<div className={classes.settingLabel}>{labels_.settings.collapse}</div>
<div className={classes.settingInputContainer}>
<Switch color="primary" checked={allCompoundsAreCollapsed} onChange={toggleAllNodesCollapsed} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using a checkbox for another boolean value (compact mode), we should use the same component for this new setting to stay consistent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csm-thu csm-thu csm-thu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OskarHowe @csm-thu