Bump SDK version and Juno v7 -> v8 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giansalex
approved these changes
Jul 7, 2022
faddat
approved these changes
Jul 7, 2022
dimiandre
approved these changes
Jul 7, 2022
|
I will let CI finish then smash the merge button since we've got 3 approving reviews. Summary of changes from where I can see:
|
joeabbey
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got stung by this bug during an upgrade:
cosmos/cosmos-sdk#11707
The fix appears to land in
0.45.6of the SDK - cosmos/cosmos-sdk#12264So we need to upgrade to
0.45.6, and increment Juno version from v7 to v8, as this is a consensus breaking change.