Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dockerfile): latest alpine, use sh, combine run #351

Merged
merged 3 commits into from
Nov 12, 2022
Merged

fix(Dockerfile): latest alpine, use sh, combine run #351

merged 3 commits into from
Nov 12, 2022

Conversation

pratikbin
Copy link
Contributor

@pratikbin pratikbin commented Nov 2, 2022 •
edited
Loading

  • Use latest alpine based golang image
  • Use sh just to standardized shells
  • combine RUN instructions
  • Use entrypoint to handle os signals

@pratikbin
fix(Dockerfile): latest alpine, use sh, combine run
95780a4 
- Use latest alpine based golang image
faddat
faddat previously approved these changes Nov 7, 2022
View reviewed changes
@faddat
Copy link
Contributor

faddat commented Nov 7, 2022

why change to sh instead of ash?

either way looks good to me

@pratikbin pratikbin requested a review from faddat November 8, 2022 05:45
@pratikbin
Copy link
Contributor Author

why change to sh instead of ash?

either way looks good to me

It's just to standardize the shell

faddat
faddat previously approved these changes Nov 8, 2022
View reviewed changes
@the-frey
Copy link
Collaborator

the-frey commented Nov 9, 2022

Triggered workflows. Let's see what CI says 🎲

the-frey
the-frey reviewed Nov 9, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@pratikbin pratikbin requested review from faddat and the-frey and removed request for faddat and the-frey November 9, 2022 14:55
@the-frey the-frey self-requested a review November 10, 2022 10:34
@the-frey
Copy link
Collaborator

Hm, although, why's it only showing 9 CI checks when other PRs are 11?

@pratikbin
Copy link
Contributor Author

code-ql only runs on go file changes and tidy and test on push.

@pratikbin pratikbin closed this Nov 10, 2022
@pratikbin pratikbin reopened this Nov 10, 2022
@vuong177 vuong177 merged commit 8093d3d into CosmosContracts:main Nov 12, 2022
vuong177 added a commit that referenced this pull request Nov 12, 2022
@vuong177
Squashed commit of the following:
9527351 
commit 8093d3d
Merge: d4e6dac 7e076ae
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Sat Nov 12 15:48:45 2022 +0700

    Merge pull request #351 from pratikbin/patch-1

    fix(Dockerfile): latest alpine, use sh, combine run

commit d4e6dac
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Sat Nov 12 15:36:23 2022 +0700

    Bumps juno version to v12 (#349)

    * bumps to v12

    * go mod

    * solve conflic with main

    * save node.go

    Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>

commit 30adf05
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Fri Nov 11 00:25:47 2022 +0700

    iavl v0.19.4 (#364)

commit d24dfbe
Merge: 0f58449 64bdef8
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Thu Nov 10 13:47:23 2022 +0700

    Merge pull request #360 from CosmosContracts/update_ica_cmd_for_v11

    Update genica command

commit 0f58449
Merge: 99a4cec e683b8f
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Thu Nov 10 00:54:45 2022 +0700

    Merge pull request #362 from CosmosContracts/revert-e2e

    Revert "Merge pull request #323 from notional-labs/ducnt/e2e"

commit e683b8f
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Wed Nov 9 22:33:45 2022 +0700

    Revert "Merge pull request #323 from notional-labs/ducnt/e2e"

    This reverts commit 99a4cec, reversing
    changes made to 49056b0.

commit 7e076ae
Author: pratikbin <68642400+pratikbin@users.noreply.github.com>
Date:   Wed Nov 9 20:24:41 2022 +0530

    fix(dockerfile): revert entrypoint

commit 99a4cec
Merge: 49056b0 763101b
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Wed Nov 9 21:48:41 2022 +0700

    Merge pull request #323 from notional-labs/ducnt/e2e

    E2E testing

commit 64bdef8
Author: Alex Lynham <alex@lynh.am>
Date:   Wed Nov 9 10:30:19 2022 +0000

    chore: now v11 has shipped, update msgs in genica

commit 49056b0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 9 10:17:47 2022 +0000

    Bump bruceadams/get-release from 1.2.3 to 1.3.2 (#333)

    Bumps [bruceadams/get-release](https://github.com/bruceadams/get-release) from 1.2.3 to 1.3.2.
    - [Release notes](https://github.com/bruceadams/get-release/releases)
    - [Commits](bruceadams/get-release@v1.2.3...v1.3.2)

    ---
    updated-dependencies:
    - dependency-name: bruceadams/get-release
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 9a806b6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 9 10:17:13 2022 +0000

    Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (#326)

    Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.1.
    - [Release notes](https://github.com/stretchr/testify/releases)
    - [Commits](stretchr/testify@v1.8.0...v1.8.1)

    ---
    updated-dependencies:
    - dependency-name: github.com/stretchr/testify
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4d19c6a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 9 10:16:52 2022 +0000

    Bump github.com/cosmos/ibc-go/v3 from 3.3.0 to 3.4.0 (#358)

    Bumps [github.com/cosmos/ibc-go/v3](https://github.com/cosmos/ibc-go) from 3.3.0 to 3.4.0.
    - [Release notes](https://github.com/cosmos/ibc-go/releases)
    - [Changelog](https://github.com/cosmos/ibc-go/blob/v3.4.0/CHANGELOG.md)
    - [Commits](cosmos/ibc-go@v3.3.0...v3.4.0)

    ---
    updated-dependencies:
    - dependency-name: github.com/cosmos/ibc-go/v3
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 07e6b4e
Merge: 1295f52 1de0920
Author: Jacob Gadikian <jacobgadikian@gmail.com>
Date:   Wed Nov 9 02:39:54 2022 +0700

    Merge pull request #321 from disperze/mint-beginblock

    (x/mint) Use new BeginBlock extension

commit 763101b
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Tue Nov 8 13:48:39 2022 +0700

    tidy

commit 9092e7b
Merge: 697c345 1295f52
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Tue Nov 8 13:47:35 2022 +0700

    Merge branch 'main' into ducnt/e2e

commit 697c345
Merge: 4d35221 b27fc7d
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Tue Nov 8 13:41:37 2022 +0700

    Merge branch 'main' into ducnt/e2e

commit 867ad82
Author: pratikbin <68642400+pratikbin@users.noreply.github.com>
Date:   Tue Nov 8 11:15:43 2022 +0530

    fix(dockefile): use entrypoint to handle os signals

commit 4d35221
Author: Duc <ntd1312000@gmail.com>
Date:   Fri Nov 4 12:38:41 2022 +0700

    Minor

commit 95780a4
Author: pratikbin <68642400+pratikbin@users.noreply.github.com>
Date:   Wed Nov 2 19:17:53 2022 +0530

    fix(Dockerfile): latest alpine, use sh, combine run

    - Use latest alpine based golang image

commit d4dc20c
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Wed Nov 2 12:26:45 2022 +0700

    Pull image from ghcr.io/cosmoscontracts/juno

commit aac4d12
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Mon Oct 31 10:19:22 2022 +0700

    When release new version => build new image for e2e test

commit 550b3ab
Author: Duc <ntd1312000@gmail.com>
Date:   Sun Oct 30 16:55:24 2022 +0700

    Test workflow for e2e testing

commit 9d32e92
Author: Duc <ntd1312000@gmail.com>
Date:   Sun Oct 30 16:13:05 2022 +0700

    Test workflow for e2e testing

commit 5a38eab
Author: Duc <ntd1312000@gmail.com>
Date:   Sun Oct 30 16:05:29 2022 +0700

    Test workflow for e2e testing

commit 8bf4a25
Author: Duc <ntd1312000@gmail.com>
Date:   Sun Oct 30 11:58:44 2022 +0700

    Test workflow for e2e testing

commit 515c62e
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 12:50:13 2022 +0700

    minor

commit 98c7dde
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 12:49:12 2022 +0700

    fix codeql.yml file

commit bcbd00f
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 12:39:20 2022 +0700

    minor

commit 0a16725
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 12:38:42 2022 +0700

    code ql auto build not working so we switch to make build

commit c8e1d62
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 12:16:52 2022 +0700

    debug = true in codeql autobuild

commit 68407ac
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 09:19:43 2022 +0700

    linting

commit dda9bbc
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Wed Oct 26 09:16:20 2022 +0700

    build tags for e2e

commit e59dad5
Author: Duc <ntd1312000@gmail.com>
Date:   Tue Oct 25 17:39:37 2022 +0700

    Fix build e2e image

commit 6ba9f45
Author: Duc <ntd1312000@gmail.com>
Date:   Tue Oct 25 17:19:13 2022 +0700

    Fix build e2e image

commit ef35032
Author: Duc <ntd1312000@gmail.com>
Date:   Tue Oct 25 17:03:58 2022 +0700

    Create special Dockerfile for E2E Test

commit 76ae237
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Tue Oct 25 09:43:29 2022 +0700

    Change TestSuite

commit 17b907b
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Mon Oct 24 10:45:56 2022 +0700

    v10 to v11

commit a5a0f02
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Sun Oct 23 22:49:26 2022 +0700

    Verifies that addreeses have correct format

commit cf5cfed
Author: Duc <ntd1312000@gmail.com>
Date:   Sun Oct 23 17:09:26 2022 +0700

    Changing

commit 8593b55
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Sun Oct 23 10:59:19 2022 +0700

    config dockerfile

commit 16362ae
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Fri Oct 21 13:22:12 2022 +0700

    Change Dockerfile

commit 0e54d60
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Thu Oct 20 16:50:03 2022 +0700

    add debug log

commit 6fd25cd
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Thu Oct 20 15:53:42 2022 +0700

    minor change : args update:

commit 47557f8
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Thu Oct 20 15:52:24 2022 +0700

    Add workflow e2e-test

commit e639ec3
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Thu Oct 20 15:01:57 2022 +0700

    Config

commit 221ebe4
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Wed Oct 19 13:35:58 2022 +0700

    Add Dockerfile for E2E Test

commit 51cc27a
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Wed Oct 19 09:25:56 2022 +0700

    Change some config

commit 1de0920
Author: Giancarlos Salas <me@giansalex.dev>
Date:   Mon Oct 17 13:04:10 2022 -0500

    Update beginBlock ext

commit 1906ef6
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Mon Oct 17 17:22:48 2022 +0700

    Change some config

commit d9cbf44
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Mon Oct 17 10:53:02 2022 +0700

    fix fix fix

commit e37524e
Author: Giancarlos Salas <me@giansalex.dev>
Date:   Sun Oct 16 11:26:18 2022 -0500

    Use BeginBlock extension

commit bb10417
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Sun Oct 16 16:55:55 2022 +0700

    minor

commit 595342d
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Sun Oct 16 15:44:59 2022 +0700

    refactor

commit 4445104
Author: vuong <nguyenvuong1122000@gmail.com>
Date:   Sun Oct 16 13:07:42 2022 +0700

    bump to v11

commit cd6987d
Merge: 04662ff 46af112
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Sun Oct 16 13:04:48 2022 +0700

    Merge branch 'CosmosContracts:main' into ducnt/e2e

commit 04662ff
Author: ducnt87 <ntd1312000@gmail.com>
Date:   Fri Oct 14 15:04:13 2022 +0700

    Add e2e test refer to osmosis

commit a6b62d3
Merge: f1750d4 ee32163
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Sat Oct 8 21:42:20 2022 +0700

    Merge pull request #8 from notional-labs/issue-template

    feature request

commit f1750d4
Merge: 1e03aae 3151046
Author: vuong <56973102+vuong177@users.noreply.github.com>
Date:   Sat Oct 8 21:07:59 2022 +0700

    Merge pull request #7 from notional-labs/issue-template

    add issue-template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@the-frey the-frey the-frey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratikbin @faddat @the-frey @vuong177