v10.9.1 #2957
v10.9.1 #2957
Conversation
ouziel-slama
commented
Jan 22, 2025
•
ouziel-slama
commented
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
Fixes and tweaks
Fix wrong fee calculation for detach and move
Bump to v10.9.1
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
pylint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Important note
Fix regression in `decode_checkmultisig()`
Add checkpoints
Merge `master` in `develop`
| query = f""" | ||
| SELECT * FROM balances |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| query = f""" | ||
| SELECT {field_name}, asset, quantity, utxo_address, MAX(rowid) |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| query = f""" | ||
| SELECT DISTINCT asset |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| query = f""" | ||
| SELECT COUNT(*) AS cnt FROM ( |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| set_data.append("block_index = :block_index") | ||
| bindings["block_index"] = CurrentState().current_block_index() | ||
| set_data = ", ".join(set_data) | ||
| sql = f"""UPDATE orders SET {set_data} WHERE tx_hash = :tx_hash""" # noqa S608 |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| def insert_record(db, table_name, record, event, event_info={}): # noqa: B006 | ||
| fields = list(record.keys()) | ||
| placeholders = ", ".join(["?" for _ in fields]) | ||
| query = f"INSERT INTO {table_name} ({', '.join(fields)}) VALUES ({placeholders})" # noqa: S608 |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| cursor.execute("SELECT last_insert_rowid() AS rowid") | ||
| inserted_rowid = cursor.fetchone()["rowid"] | ||
| new_record = cursor.execute( | ||
| f"SELECT * FROM {table_name} WHERE rowid = ?", # noqa: S608 |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
| "SELECT asset, SUM(total) AS total FROM (" # noqa: S608 | ||
| + " UNION ALL ".join(queries) |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
