Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Validate gradle wrapper and update gradle scripts #115

Closed
wants to merge 3 commits into from
Closed

[Android] Validate gradle wrapper and update gradle scripts #115

wants to merge 3 commits into from

Conversation

hannesa2
Copy link

@hannesa2
Copy link
Author

I guess you have to enable Github actions

@hannesa2
Copy link
Author

When you enable Github actions, you will see your gradle jar file has a wrong checksum

https://github.com/hannesa2/countly-sdk-android/pull/1/checks?check_run_id=876276329

image

@hannesa2
Copy link
Author

Now it works
image

@ArtursKadikis ArtursKadikis changed the base branch from master to staging August 1, 2022 12:28
@arifBurakDemiray arifBurakDemiray changed the title Gradle verify [Android] Validate gradle wrapper and update gradle scripts Jan 30, 2024
@arifBurakDemiray
Copy link
Member

To generate and add a gradle wrapper -> https://stackoverflow.com/a/25770202

@arifBurakDemiray
Copy link
Member

@hannesa2 Thank you very much for your contribution. We will take action for it. I have updated scripts and workflow file with the most updated ones. I have also opened a new PR for fresh generated gradle-wrapper.jar for version 7.5 #212

name: "Validation"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the versions

@@ -37,7 +37,7 @@ android {
path file('src/main/cpp/CMakeLists.txt')
}
}
ndkVersion '21.0.6113669'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please open a different pr for this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise I can't do a
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let us discuss this. I will write back here after discussion

Copy link
Member

@arifBurakDemiray arifBurakDemiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some things to consider

@hannesa2
Copy link
Author

some things to consider

Sorry to say this. After 3 (!) years of silence, my focus is now somewhere else. I work for other topics and projects now. See it as suggestion.
Merge it, change it, or close it.

@ArtursKadikis
Copy link
Member

Hello, we merged a modified version of this.
Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants