Feat/pre assignation #101
Merged
Feat/pre assignation #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 23, 2024 17:45
added 2 commits
May 31, 2024 11:32
| nextDocumentStatus, | ||
|
|
||
| // Check first pre-assignation by documentNumber and then by appelNumber | ||
| let preAssignationForDocument = await preAssignationService.fetchPreAssignationBySourceAndNumber( |
There was a problem hiding this comment.
je pense que faire : let preAssignationForDocument = await preAssignationService.fetchPreAssignationBySourceAndNumber( documentNumber.toString(), source, ) || await preAssignationService.fetchPreAssignationBySourceAndNumber( appealNumber, source, ); c'est pareil soit l'un est undiefined donc il passe à l'autre
| extractor: (preAssignation) => | ||
| preAssignation.preAssignation.creationDate | ||
| ? timeOperator.convertTimestampToReadableDate(preAssignation.preAssignation.creationDate) | ||
| : '-', |
There was a problem hiding this comment.
la preassignation est sensé avoir une date de création à sa création. Pourquoi une boolean et '-' ?
Bouba-cassation
approved these changes
May 31, 2024
ajeanneney
added a commit
that referenced
this pull request
Jun 3, 2024
* create model and repositories to preAssign decision * add preAssignation service tests * create pre assignation api endpoints * fix import in controller * create assignation when there is a preAssignation after nlp annotation * add delete preassignation route on api * first step for frontend * create delete oprtion * get userName instead of userId * refetch on delete * add pre-assignation creation button * add pre assignation creation * lint * adapt clear db * fix tests * fix to run script without docker * change behavior to accept appealNumbers * fix docker start * reset path to storage * fix paths to execute scripts * changes from review --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
ajeanneney
added a commit
that referenced
this pull request
Jun 3, 2024
* create model and repositories to preAssign decision * add preAssignation service tests * create pre assignation api endpoints * fix import in controller * create assignation when there is a preAssignation after nlp annotation * add delete preassignation route on api * first step for frontend * create delete oprtion * get userName instead of userId * refetch on delete * add pre-assignation creation button * add pre assignation creation * lint * adapt clear db * fix tests * fix to run script without docker * change behavior to accept appealNumbers * fix docker start * reset path to storage * fix paths to execute scripts * changes from review --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
s-diallo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* create model and repositories to preAssign decision * add preAssignation service tests * create pre assignation api endpoints * fix import in controller * create assignation when there is a preAssignation after nlp annotation * add delete preassignation route on api * first step for frontend * create delete oprtion * get userName instead of userId * refetch on delete * add pre-assignation creation button * add pre assignation creation * lint * adapt clear db * fix tests * fix to run script without docker * change behavior to accept appealNumbers * fix docker start * reset path to storage * fix paths to execute scripts * changes from review --------- Co-authored-by: Antoine Jeanneney <antoine.jeanneney@justice.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description :
You can set a pre-assignation for a document, after its annotation, the document is automatically assigned to the specified user
Describe your changes :
How to test :
Checklist before requesting a review