This repository has been archived by the owner on May 23, 2023. It is now read-only.
mode 9/10 fixes and very basic seed calculator #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schwiti6190
commented
Jan 21, 2021
•
schwiti6190
commented
- improves mode 10 fillup and compacting ( mode 10 driver driving into silo wall #6623 Silo verdichten #6610 Leveler doesn't change columns in silo bunker? #6640 Silo bug. Blade taps all areas but does not level. #6664 Bunker tractors slipping issue #6682 )
- fixes a lua errors mode 10 ( [BUG] Mode 10 Modus Verdichten Funktioniert nicht #6661, Exception, stopping Courseplay driver, #6636 )
- fixes mode 9 unloading at trailer bugs ( Mode 9 still does not work #6447 )
- added a very basic seed calculator with field size ( Calulate field size with border #4717 )
- small adjustment to mode 4 loading at waitpoint
- fixes problem with drivable implements, double hud (Dual HUD when driving with a drivable attachment #3690 )
- improves mode 10 fillup and compacting - fixes a lua errors mode 10 - fixes mode 9 unloading at trailer bugs - added a very basic seed calculator with field size - small adjustment to mode 4 loading at waitpoint
pvaiko
suggested changes
Jan 21, 2021
base.lua
Outdated
| @@ -831,7 +844,10 @@ end; | |||
|
|
|||
| function courseplay:onUpdateTick(dt) | |||
| --print("base:courseplay:updateTick(dt)") | |||
|
|
|||
| --if the vehicle is attached to another vehicle, disable cp | |||
| if self.spec_attachable and self.spec_attachable.attacherVehicle then | |||
There was a problem hiding this comment.
This should be in a function since we used it now three times.
gui/CourseGeneratorScreen.lua
Outdated
| -- draw all the sprayTypes and fruitType | ||
| for _,sprayType in pairs(g_sprayTypeManager:getSprayTypes()) do | ||
| local litersPerSecond = sprayType.litersPerSecond | ||
| local totalLiters = litersPerSecond*fieldAreaHa*36000 |
There was a problem hiding this comment.
Not saying this is wrong, just wondering how is this calculated, where the 36000 is coming from (a comment would have been nice)
input.lua
Outdated
| if not vehicle or not vehicle.hasCourseplaySpec then return end | ||
| courseEditor:updateMouseState(vehicle, posX, posY, isDown, isUp, mouseButton) | ||
|
|
||
| --if the vehicle is attached to another vehicle, disable mouse input |
There was a problem hiding this comment.
and here, a fourth time. We may already have something for this, and probably name it more generic, like isCourseplayEnabled?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.