This repository has been archived by the owner on May 23, 2023. It is now read-only.
Diff fixes #7126
Merged
Diff fixes #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schwiti6190
commented
Apr 23, 2021
•
schwiti6190
commented
- small action event improvements.
- added a global setting to disable action event texts.
- fixes Question: Shovel Mode #7051, fixes Mode 3 Save pipe position #6810, fixes Mode 3 : Overloader does not brake at the overload point (to high speed when approach waitpoint ?) #6611
- added the possibility to print variables to drifferent xml files
- added printGlobalCpVariable()
pvaiko
reviewed
Apr 23, 2021
ActionEventsLoader.lua
Outdated
| ---Needs the action event text to be visible? | ||
| ---@param table actionEventData from the config xml | ||
| function ActionEventsLoaderUtil.isActionEventTextVisible(actionEventData) | ||
| return courseplay.globalSettings.showActionEventsTexts:get() or actionEventData.textVisibilityNeeded |
There was a problem hiding this comment.
would textAlwaysVisible describe textVisibilityNeeded better what it is for?
pvaiko
reviewed
Apr 23, 2021
base.lua
Outdated
| ---Post init function, as not all giants variables are | ||
| ---set correctly at the first courseplay:setAIDriver() call. | ||
| self.cp.driver:postInit() | ||
| self.cp.firstRun = true |
There was a problem hiding this comment.
This is confusing, if firstRun is true, I'd think it is the first run, but the opposite seems to be the case. I'd recommend renaming it to postInitDone or something more descriptive.
config/ActionEventsConfig.xml
Outdated
| @@ -16,6 +16,7 @@ | |||
| isDisabledCallbackFunc: is used to disable a action event after a action event refresh or on load. | |||
| callbackState: isDisabledCallbackFunc parameter, this is an int! | |||
| text: is the action event text, by default it returns courseplay:loc(name), where 'name' is the previous defined action event name. | |||
| textVisibilityNeeded: Is disabling action event text forbidden ? (default: false) | |||
There was a problem hiding this comment.
very confusing description (maybe it is due to my age :) but disabling forbidden is false is just too much boolean logic for me...
pvaiko
approved these changes
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.