Introduce a batch mode #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
commented
Nov 29, 2024
bbannier
force-pushed
the
t/batch
branch
2 times, most recently
from
a202095 to
d43f9c5
Compare
|
@CrabeDeFrance, I believe this is ready for review. I have added a smoke test making sure the functionality roughly works, but I did not do deep inspection of how |
|
Thanks for your patch proposal. I don't know exactly if this is a good idea to add a new "spawn" method named batched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a batch mode which is intended for cases where no Rust-side access to individual packets is needed (e.g., when an output file was configured).
Closes #25.