Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/catchup #1654

Merged
merged 25 commits into from
Jan 16, 2025
Merged

Fix/catchup #1654

merged 25 commits into from
Jan 16, 2025

Conversation

woksin
Copy link
Contributor

@woksin woksin commented Jan 16, 2025 •
edited
Loading

Summary

We were noticing inconsistencies and wrong results when catching up events. This is now fixed

Added more integration tests around Observers and specifically Catchup for Observers in different states

Added

  • Functionality for directly registering Reactors and Reducers by type from the Client

Changed

  • Contracts for handling of events for Reducers and Reactors to include Partition key

Fixed

  • Catching up observers
  • Replaying observers
  • An issue where handling events for ar Reducer would fail if the method was an asynchronous Task
  • An issue with handling events in parallel across multiple partitions

woksin and others added 15 commits January 15, 2025 13:02
@woksin
Start on integration tests
5e39d2c
@einari @woksin
Reproducing a problem with catch up
7af0525 
Co-authored-by: Sindre Alstad Wilting <woksin@users.noreply.github.com>
@einari
Simplifying naming - removing unneded Concepts namespace
6839ccd
@einari
Adding explicit CaughtUp call when the catchup observer job is completed
cea4c6e
@einari
Specs
9a6ebe4
@einari
Splitting specs into single and multiple partitions
e4bf4d8
@einari
refactor
5a2bb56
@einari @woksin
Making Reactors work in parallel partitions, fixing CatchUp to notify…
799f531 
… observer when done

Co-authored-by: Sindre Alstad Wilting <woksin@users.noreply.github.com>
@einari @woksin
Fixing Reducers to handle parallel partitions
cb489b1 
Co-authored-by: Sindre Alstad Wilting <woksin@users.noreply.github.com>
@einari
FIxing so that we are inclusive on the From event sequence number
3044d29
@einari
Making completion task source dictionaries concurrent
fcf6080
@einari
Using the incoming partition rather than deducing it ourselves
a6a8196
@einari
Fixing typo in XML Doc
9d203cc
@einari
Removing reentrant - this should not be reentrant as state can then b…
f01a83e 
…ecome out of sync
@einari
Adding specs to verify that we process all events
0ae1e32
@woksin woksin added the major label Jan 16, 2025
@einari einari added patch and removed major labels Jan 16, 2025
@einari einari merged commit 072fc6c into main Jan 16, 2025
9 of 12 checks passed
@einari einari deleted the fix/catchup branch January 16, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woksin @einari