CASMCMS-9146: Add BOS option ims_images_must_exist #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
force-pushed
the
casmcms-9146
branch
5 times, most recently
from
3a09bfd to
2c6e8b0
Compare
mharding-hpe
force-pushed
the
casmcms-9146
branch
2 times, most recently
from
ff0a4c6 to
be71e2d
Compare
mharding-hpe
force-pushed
the
casmcms-9146
branch
from
be71e2d to
3a5f893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new BOS v2 option --
ims_images_must_exist. It governs what happens when validating boot sets whose images appear to be from IMS (based on their S3 paths). Specifically, it governs what happens when these images do not actually exist in IMS.If the option is false (the default), then a warning is logged, but the validation is not failed on this basis.
If the option is true, then the validation is failed in this case.
If this option is true, then if the image appears to be from IMS and IMS is unreachable, then ...
BOS needs to get image arch data from IMS, and there is an error getting it (other than the image not being in IMS). Currently, in that situation, an error is logged, but the architecture validation is skipped. If this new option is false (as it will be by default), then the current behavior will continue.
If this new option is true, then IMS errors will be considered fatal. If a boot set is being validated and one of these errors comes up, then the boot set validation will fail.
I tested this on mug, verifying that I got the correct behavior for both settings of the option, with IMS both up and down.