Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9162: Add cfs_read_timeout option #385

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jsollom-hpe
Copy link
Contributor

@jsollom-hpe jsollom-hpe commented Oct 15, 2024

Summary and Scope

Add cfs_read_timeout option

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

  • Resolves [issue CASM-9162](issue link)
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

List the environments in which these changes were tested.

Tested on:

  • <development system>
  • Local development environment
  • Virtual Shasta

Test description:

Once it builds, I'll test it a CSM-1.5 system.

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@jsollom-hpe jsollom-hpe requested a review from a team as a code owner October 15, 2024 20:38
Copy link
Contributor

@mharding-hpe mharding-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update ./src/bos/server/controllers/v2/options.py

It wasn't necessary for CSM 1.6 because I refactored the code to remove the redundancy, but it's still needed for prior versions.

@jsollom-hpe jsollom-hpe force-pushed the CASMCMS-9162-release-2.10 branch from 70e6448 to 6dffb07 Compare October 16, 2024 13:50
@jsollom-hpe jsollom-hpe merged commit cfb5c41 into release/2.10 Oct 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants