-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to control the PCS transition deadline #391
Open
jsollom-hpe
wants to merge
1
commit into
develop
Choose a base branch
from
PCS_TRANSITION_DEADLINE_OPTION
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concern I have is that I notice we are defaulting to 60 minutes for the deadline. Prior to this PR, our calls to PCS did not specify a deadline, meaning it would end up using the PCS default value of 5 minutes.
With a deadline of 60 minutes, for a node which is not behaving nicely with PCS, this could result in BOS creating a bunch of transitions in PCS for the same node, before any of these transitions hit their deadlines. I don't know enough about how PCS works to know how it handles this situation, or if there is the potential for problems. This just is different than the CFS option we added, where by default everything would behave the same as before, and things would only be different if the option was set by the user to a non-default value.
Thinking about it now, it almost seems like it would make more sense for us to specify a deadline that is no larger than the time left before BOS gives up on the node, right? Like if we're trying to power on a node, and there's only 4 more minutes before BOS is going to timeout and power off the node to retry, then it seems like our power on call shouldn't have a deadline more than 4 minutes (since a transition after that point doesn't help BOS anyway, right?).
It doesn't mean we couldn't also have an option like this, but it seems like we'd want to take the lower of the two values -- our time left before timeout and whatever is specified by this option.
Does that make sense?