Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-8713: Temporarily modify PyYAML, kubernetes install procedure #263

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Jul 17, 2023

Summary and Scope

Cray Product Catalog builds started failing recently, due to yaml/pyyaml#601. Because CPC is using an Alpine container, and because the kubernetes Python module has a dependency on PyYAML >= 5.4, this PR represents the simplest workaround I was able to come up with. (Essentially, it forces the install of PyYAML inside the Docker container to use an older version of Cython). The PR is careful to only make this change when installing the PyYAML module and (because it has a dependency on PyYAML) the kubernetes module. I tried doing it with the modification limited to the PyYAML module, but the problem persisted until I pulled the kubernetes module in as well.

This should only be a temporary workaround. There is a PR up for PyYAML that will allow us to remove this workaround, but it's not clear when it will be merged and released. That PR is: yaml/pyyaml#702

This CPC workaround PR should have no functional impact on CPC. It will just allow the builds to continue working.

Issues and Related PRs

Testing

None beyond making sure the build worked (which itself includes a run of the regression tests).

Risks and Mitigations

Without this, the CPC is unbuildable.

Dockerfile Show resolved Hide resolved
… in Dockerfile to workaround upstream PyYAML issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants