MTL-2284 opsie #24
Merged
MTL-2284 opsie #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mkfs.xfs` line was referencing an undefined variable `$target`, this prevents the FSLabel from applying (as well as the filesystem). Also, the letter index is off by 1. It starts at `b` instead of `a`. This ensures the index doesn't use non-alpha characters, starts at `a`, and (when referenced) the letters are capitalized.
`{}/${}` are unnecessary in arithmetic operations.
During an install with the fawkes tarball we can save the user a manual step by extracting the hypervisor ISO for them.
If the fawkes tarball is not found, and no hypervisor ISO is present in the data partition from a remote download, then the fawkes-liveCD should abort the disk install. Without this conditional, the installer will install the fawkes image to disk. This is undesirable.
rustydb
force-pushed
the
MTL-2284-opsie
branch
from
0347145 to
c27894e
Compare
The `VMSTORE` partitions were all mounting to `/vms`, which is broken and incorrect. This ensures they all mount to their respective location.
Ensure that `/vms/store0/assets` is created before copying files into it. Also do not bother remounting `/data` as it is mounted at the beginning of the script.
rustydb
force-pushed
the
MTL-2284-opsie
branch
4 times, most recently
from
fb63879 to
b90d4ae
Compare
The `domain.xml` needs to point to the current cloud-init ISO. Also, always restore the original files from the booted squash.
rustydb
force-pushed
the
MTL-2284-opsie
branch
from
b90d4ae to
af3090c
Compare
This was referenced Oct 24, 2023
jacobsalmela
approved these changes
Oct 24, 2023
manderson-hpe
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #23 , fixes letter indexes.