Update RPM in the OverlayFS and Run-through Fixes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install and wipe scripts are pretty complicated, and having a full call trace for each run is pretty valuable.
In my testing, I forgot to extract the tarball and thus had no images to load. This caused the script to fail in a confusing manner. This adds a safeguard to prevent that confusion.
This code could fail, it hasn't been tested. Attempt to update the crucible RPM in the Fawkes liveCD.
rustydb
requested review from
muresan,
heemstra,
manderson-hpe and
jpdavis-prof
manderson-hpe
approved these changes
Jan 5, 2024
rustydb
added a commit
to Cray-HPE/metal-provision
that referenced
this pull request
Jan 5, 2024
Includes fixes from Cray-HPE/crucible#33
rustydb
added a commit
to Cray-HPE/fawkes
that referenced
this pull request
Jan 5, 2024
Contains fixes from Cray-HPE/crucible#33
rustydb
added a commit
to Cray-HPE/fawkes
that referenced
this pull request
Jan 5, 2024
Contains fixes from Cray-HPE/crucible#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
The primary change for this PR is a new function of the install and write-livecd script that updates the Crucible package with what was included in the Fawkes assets. This allows us to do a few things:
There is a gap at the moment for the PXE installed hypervisors, these are waiting on an additional change to auto-fetch the new Crucible (MTL-2300).
This also includes:
Prerequisites
Idempotency
Risks and Mitigations
This does add some prototype code for the USB drive that may or may not work, but shouldn't interfere with anyone's runthrough.