Fixes #48
Merged
Fixes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of these commands were copy-pasted without a complete refactor and have duplicated values.
The code responsible for updating Crucible when creating bootable media was not doing anything.
This has been causing me grief every Fawkes install, I fail to capy the archive into my bootable. The docs don't say to do this by hand because they aren't written for the scenario where you reinstall from a running hypervisor. The docs expect the tar to be available on a workstation or server in the system's peripheral. This ensures the tar/extracted is included on the bootable, so I don't lose it when I wipe and reboot.
These two commands were poorly constructed, they must refer to the domain by its name not by its XML. The way it sits causes the script to fail.
jpdavis-prof
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from the 0.0.1-beta.1 install on Redbull.