CASMTRIAGE-7569: Add unused drives test to upgrade suite and add note…

…s about running tests (#647)

* Add unused drives test to upgrade tests and add comment

Co-authored-by: Lindsay Eliasen <87664908+leliasen-hpe@users.noreply.github.com>
Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>

goss-testing/suites/ncn-storage-tests.yaml

@@ -1,7 +1,7 @@
 #
 # MIT License
 #
-# (C) Copyright 2021-2023 Hewlett Packard Enterprise Development LP
+# (C) Copyright 2021-2024 Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -24,6 +24,7 @@
 
 #
 # This suite is run during CSM installs before CSM services have been deployed
+# Note: This suite is only executed from the PIT node.
 #
 
 # Use hostname from variable file, if set.

goss-testing/suites/ncn-upgrade-tests-storage.yaml

@@ -1,7 +1,7 @@
 #
 # MIT License
 #
-# (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
+# (C) Copyright 2021-2024 Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -21,10 +21,18 @@
 # ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 # OTHER DEALINGS IN THE SOFTWARE.
 #
+
+# Note: The tests in this suite must be run using an automated script
+# that uses the `run_goss_tests` helper function.
+# This suite can be run by executing `/opt/cray/tests/install/ncn/automated/ncn-upgrade-tests-storage`.
+# This is required due to a temporary values file generated in the `run_goss_tests` function.
+# that will allow the tests to identify storage nodes.
+
 gossfile:
   ../tests/goss-check-static-routes.yaml: {}
   ../tests/goss-ceph-storage-health.yaml: {}
   ../tests/goss-lvm-drives-storage.yaml: {}
   ../tests/goss-ceph-storage-config-files.yaml: {}
   ../tests/goss-check-clock-skew.yaml: {}
   ../tests/goss-rgw-health.yaml: {}
+  ../tests/goss-unused-drives-on-storage-nodes.yaml: {}