CASMTRIAGE-7316 add additional check to the bgp test to check for the #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state of metallb-speaker After checking with SME, @spillerc-hpe, I learned it is possible for BGP to not be up when running the neighbour test from these conditions: - Bad or no credentials from vault - The node is not yet up: - metallb-speaker isn't running on the node - BGP session has gone idle: [https://www.arubanetworks.com/techdocs/AOS-CX/10.07/HTML/5200-7858/Content/Chp_BGP/bgp-nei-sta27.htm](https://www.arubanetworks.com/techdocs/AOS-CX/10.07/HTML/5200-7858/Content/Chp_BGP/bgp-nei-sta27.htm) - A misconfigured switch - The switch configuration can be wrong, but customers can also use BGP to connect to their own network that can lead to false positives. This PR aims to reduce the need to re-run this test, which can often work if the pods are running after the initial failure, which has been observed in the JIRA. New output from this change as seen below: ``` ncn-w004:~ # /opt/cray/tests/install/ncn/scripts/check_bgp_neighbors_established.sh Running in interactive mode NAME DATA AGE metallb 1 30d Able to get metallb configmap from Kubernetes metallb-speaker pods: false <------------------------ ERROR: metallb-speaker pods are not ready, which can cause this test to fail FAIL ncn-w004:~ # echo $? 16 ``` It also reports if the pods are ok: ``` ncn-w004:~ # /opt/cray/tests/install/ncn/scripts/check_bgp_neighbors_established.sh Running in interactive mode NAME DATA AGE metallb 1 30d Able to get metallb configmap from Kubernetes metallb-speaker pods: true <---------------------- ``` Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
spillerc-hpe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state of metallb-speaker
After checking with SME, @spillerc-hpe, I learned it is possible for BGP to not be up when running the neighbour test from these conditions:
This PR aims to reduce the need to re-run this test, which can often work if the pods are running after the initial failure, which has been observed in the JIRA.
New output from this change as seen below:
It also reports if the pods are ok: