Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use find cmd instead of static path for finding goss-server pids #607

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jacobsalmela
Copy link
Contributor

the path the file is found at can vary between nodes, so using the find command is safer and more resilient.

the path the file is found at can vary between nodes, so using the find
command is safer and more resilient.

Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela self-assigned this Oct 21, 2024
@jacobsalmela jacobsalmela marked this pull request as ready for review October 21, 2024 13:45
@jacobsalmela jacobsalmela requested a review from a team as a code owner October 21, 2024 13:45
Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobsalmela jacobsalmela merged commit c4e9c91 into release/1.6 Oct 21, 2024
3 checks passed
@jacobsalmela jacobsalmela deleted the summary-blade branch October 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants