CASMPET-7270: Remove RPM dependency on requests-retry-session #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to CSM 1.6.1 failed because it could not install
csm-testinginprerequisites.sh. The install failure was because a required RPM (forrequests-retry-session) could not be found. That required RPM is present in the CSM tarball, but the logic used inprerequisites.shassumes that all dependencies are already installed on the node -- it does not handle the case where it has to pull in additional RPMs from the CSM tarball.Long term we should fix that, but it's slightly tricky, and for this specific issue, it's not a problem just to move the
requests-retry-sessioninto thecsm-testingvirtual environment. That way thecsm-testingRPM does not need to be dependent on therequests-retry-sessionRPM, because the content it needs is built into it.So this PR does exactly that -- installs the
requests-retry-sessionPython module into the virtual environment, and remove it as a dependency of the RPM.I got onto vex (the vshasta system which hit this problem) and verified that these changes allow the RPMs to install (and I also checked and verified that goss-servers started successfully).