CASMAUTO 32 : adding IUF BATS #629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankhuri-Rajesh
requested review from
mharding-hpe and
rajeshranganathan-hpe
mharding-hpe
requested changes
Nov 13, 2024
Srinivas-Anand-HPE
force-pushed
the
CASMAUTO-32
branch
6 times, most recently
from
18b9106 to
dd75b9f
Compare
all the tests can run on Vshashta |
Srinivas-Anand-HPE
force-pushed
the
CASMAUTO-32
branch
from
470a84d to
4e8e1ad
Compare
arkaja2811
force-pushed
the
CASMAUTO-32
branch
from
4e8e1ad to
71cd606
Compare
jacobsalmela
requested review from
mbuchmann-hpe,
dlaine-hpe,
jnowicki-hpe,
shunr-hpe and
ganeshs-hpe
Pankhuri-Rajesh
force-pushed
the
CASMAUTO-32
branch
2 times, most recently
from
d2c4b2d to
2fff786
Compare
jacobsalmela
approved these changes
Nov 22, 2024
mharding-hpe
requested changes
Nov 22, 2024
Signed-off-by: Mitch Harding <mitchell.harding@hpe.com>
|
Hi @Pankhuri-Rajesh, can we please set up a time to discuss the intention of these tests and the possible overlap with the automated tests that the SAT team (me, @ethanholen-hpe, and @annapoorna-s-alt) is developing? One thing I saw here really concerns me, which is that the entire JSON Schema files (for bootprep input files and IUF product manifest files) are being copied into this repository. I would like to understand why that is being done and come up with a better solution. Thank you! |
Srinivas-Anand-HPE
approved these changes
Dec 13, 2024
…as we need to consider all non-zero exit code as error
goss-testing/tests/ncn/goss-sat-validate-management-bootprep.yaml
Outdated
Show resolved
Hide resolved
goss-testing/tests/ncn/goss-sat-validate-compute-uan-bootprep.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitch Harding <mitchell.harding@hpe.com>
mharding-hpe
requested changes
Dec 13, 2024
Comment on lines
+68
to
+71
| # Exit with code 1 if test case failed with exit code 1 | ||
| if [ $run_exit_code_1 -eq 1 ] || [ $run_exit_code_2 -eq 1 ]; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Should this also not fail if the subtests returned other non-0 return codes?
Suggested change
| # Exit with code 1 if test case failed with exit code 1 | |
| if [ $run_exit_code_1 -eq 1 ] || [ $run_exit_code_2 -eq 1 ]; then | |
| exit 1 | |
| fi | |
| # Fail if either subtest failed | |
| [[ $run_exit_code_1 -ne 0 ]] && exit $run_exit_code_1 | |
| exit $run_exit_code_2 |
Signed-off-by: Mitch Harding <mitchell.harding@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Adding the files for IUF test cases which have been automated and are to be made a part of CSM 1.6
Changes-
1. All the goss files for IUF placed under ncn folder. (file name starts with "goss-iuf-")
2. All python scripts are placed under src/csm-testing/tests and lib.
3. iuf_run_setup is the folder containing the dummy-product tar file which will be used for running the tests (mainly IUF stages till prepare-images) and the manifest files which is placed in goss-testing/scripts.
4. New variables-iuf.yaml file added under vars folder.
Issues and Related PRs
Testing
Scripts have been tested by directly installing the modules on the system. Testing with virtual environment is in progress.
Tested on:
Pull Request Checklist