CASMPET-7290: Add pylint to build pipeline; correct errors identified by pylint #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
requested review from
rustydb,
bo-quan,
jsl-hpe,
jsollom-hpe,
mbuchmann-hpe,
schooler-hpe,
leliasen-hpe,
jwlv,
jpdavis-prof and
a team
No problem -- this is something I've been trying to do in a lot of repos. I also want to eventually add mypy, but for that we'll need to make sure the code has type annotations, and that'll also take a little while. But that has allowed me to find a bunch of bugs in BOS, so I'm hoping to eventually get this done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pylint to the build pipeline. The builds will only fail if pylint identifies fatal errors. A full pylint run will also happen, but currently it will not be able to cause the build to fail. This is because there are a lot of issues it identified in the existing Python code. Hopefully we can gradually address those. If so, we can eventually have pylint require minimum code quality, or else fail the build.
After adding pylint, it identified several fatal errors in the existing tests. This PR corrects those as well. None of them are tricky or risky changes.