Support multiple discriminator mappings to share one type #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, CreateAPI only supports a unique type for each mapping case.
For example, if we have
it only generates
.a
but.d
is not generated.This is because we only use the first case with the property type.
CreateAPI/Sources/CreateAPI/Generator/Templates.swift
Line 314 in a59c766
How
In this PR, I have fixed the issue above by checking the
mapping
keys and updated the discriminator test case for the case when two enum cases share one type.Hope the changes make sense. Let me know if you have better options 🙇🏽