-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple discriminator mappings to share one type #36
Merged
liamnichols
merged 5 commits into
CreateAPI:main
from
imjn:fix-wrong-generation-of-oneOf
Jun 9, 2022
Merged
Support multiple discriminator mappings to share one type #36
liamnichols
merged 5 commits into
CreateAPI:main
from
imjn:fix-wrong-generation-of-oneOf
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjn
force-pushed
the
fix-wrong-generation-of-oneOf
branch
3 times, most recently
from
May 16, 2022 15:55
358c5c5
to
1e1caa4
Compare
imjn
force-pushed
the
fix-wrong-generation-of-oneOf
branch
from
May 16, 2022 15:56
1e1caa4
to
9889dab
Compare
imjn
changed the title
Fixed wrong generation of oneOf
Support multiple discriminator mappings to share one type
May 16, 2022
liamnichols
reviewed
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! It's looking good 💪💪💪
Co-authored-by: Liam Nichols <liam.nichols.ln@gmail.com>
Co-authored-by: Liam Nichols <liam.nichols.ln@gmail.com>
imjn
force-pushed
the
fix-wrong-generation-of-oneOf
branch
from
June 7, 2022 15:55
576b9f6
to
9701306
Compare
liamnichols
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @imjn, great work! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, CreateAPI only supports a unique type for each mapping case.
For example, if we have
it only generates
.a
but.d
is not generated.This is because we only use the first case with the property type.
CreateAPI/Sources/CreateAPI/Generator/Templates.swift
Line 314 in a59c766
How
In this PR, I have fixed the issue above by checking the
mapping
keys and updated the discriminator test case for the case when two enum cases share one type.Hope the changes make sense. Let me know if you have better options 🙇🏽