Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftUI Text.init(_ date: NaiveDate, style: Text.DateStyle) utility #1

Open
robmaceachern opened this issue Jan 20, 2022 · 2 comments

Comments

@robmaceachern
Copy link

Thanks for the helpful library. I discovered it as part of Create API and it's wonderful!

I was wondering if you'd be interested in adding a SwiftUI Text.init(_ date: NaiveDate, style: Text.DateStyle) utility, in the same style as Text.init(_ date: Date, style: Text.DateStyle).

I think it'd be helpful (I was reaching for it today) but I'm not sure if it'd be a fit as part of this package.

@kean
Copy link
Member

kean commented Jan 25, 2022

Yes, NaiveDate has some convenience localizable strings formatting. I don't mind adding it. PRs are welcome.

@lvalenta
Copy link
Contributor

lvalenta commented Sep 12, 2024

I implemented it here: #6 – however, we can only make Text.init(_ date: NaiveDate, format: NaiveDate.FormatStyle). Looking forward for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants