fix: Resolve issue with book & quills on lectern contraptions #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Creators-of-Create#7253. Where an attempt to parse JSON out of a writable book (not a written book), which has raw string data for the pages array caused a game crash.
|
Drafting this because I will do some further testing, I might have found some other issues. |
IThundxr
added
pr type: fix
Instead of checking if the book has an author, check if it specifically is a writable book by id
|
Went and looked at why things were being done the way they were and it is all about sanitizing nbts that could be exploited, so I changed the check to explicitly check for the writable book which is causing the crash as opposed to letting any books without an author tag through since it is a security matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7253. Where an attempt to parse JSON out of a writable book (not a written book), which has raw string data for the pages array caused a game crash.
Compound tags for a written book on a lectern:
{Book:{Count:1b,id:"minecraft:written_book",tag:{author:"Dev",filtered_title:"aa",pages:['{"text":"aaaa"}','{"text":"bbbb"}'],resolved:1b,title:"aa"}},Page:0,id:"minecraft:lectern"}Compound tags for a writable book on a lectern:
{Book:{Count:1b,id:"minecraft:writable_book",tag:{pages:["cccc","ddddd"]}},Page:0,id:"minecraft:lectern"}An attempt to parse "cccc" as JSON caused the crash.