Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 fixes #192

Merged
merged 5 commits into from
Oct 3, 2021
Merged

2.0 fixes #192

merged 5 commits into from
Oct 3, 2021

Conversation

ooliver1
Copy link
Contributor

@ooliver1 ooliver1 commented Oct 2, 2021

Seems to be no PR template:
closes #176
lmk if I missed any 2.0 changes, couldn't find much apart from assets that needed updating for 2.0

++I come from hacktoberfest, if this looks good please give an approving review even if you can't merge right now

@Dhruvacube Dhruvacube self-requested a review October 3, 2021 00:44
@Dhruvacube Dhruvacube added bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed labels Oct 3, 2021
@Dhruvacube
Copy link
Member

Well hi @ooliver1 , thanks for taking out time and helping me to resolve that discord.py 2.0 compatibility issue, it seems a lot of changes were made. As soon I get time , I go and run this to check if there something missing out. Other thanks a lot 🤝

@Dhruvacube
Copy link
Member

Well yeah TBH some parts like assets and all broke, since broke thus I created an issue, so that it helps me to remind that I have fix it :)

@Dhruvacube Dhruvacube merged commit 906a53f into Creatrix-Net:master Oct 3, 2021
Copy link
Member

@Dhruvacube Dhruvacube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved , thanks for the valuable contribution.

@Dhruvacube Dhruvacube added this to the v2.0 milestone Oct 27, 2021
@Dhruvacube
Copy link
Member

@all-contributors lets add @ooliver1 for Maintenance

@allcontributors
Copy link
Contributor

@Dhruvacube

I've put up a pull request to add @ooliver1! 🎉

Dhruvacube added a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

discord.py2.0 compatibilty issue
2 participants