This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Fix bot.py send_attachment bug and test script #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bot.py has the following bugs:
- send_audio pass “image” to send_attachment
- not closing file
- extra {} around payload[“recipient”] and payload[“message”]
- wrong usage of MultipartEncoder (payload key value should be JSON-string or tuple)
- not specifying content-type when uploading attachment to Facebook
- wrong url in requests.post
|
Looks good. Thank you very much for this commit, will close #11 for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bot.py has the following bugs:
It should fix #11