Add timeout to requests.get, simplify try except in method "Scraper.get_info" and format with Black #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout set to 10 seconds
Instead of two except (one for AttributeError and one ValueError) is now one except
Crinibus
added a commit
that referenced
this pull request
Jan 22, 2022
commit b0b4090 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Jan 21 16:47:10 2022 -0800 Fix a typo in README.md commit a448cd6 Merge: e05edf0 6caa95b Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Thu Dec 16 22:41:09 2021 +0100 Merge pull request #148 from Crinibus/dev Move some functions from main.py to scraper module commit e05edf0 Merge: 4530f4a a8a8483 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Mon Dec 13 00:06:18 2021 +0100 Merge pull request #147 from Crinibus/dev Update visualize.py commit 4530f4a Merge: 8e8fbdc 6f84c66 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Thu Sep 23 18:31:29 2021 +0200 Merge pull request #144 from Crinibus/dev Add url in requests exception string in method Scraper.request_url commit 8e8fbdc Merge: 76b65c1 ff4f3b4 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Mon Jun 7 00:01:23 2021 +0200 Merge pull request #143 from Crinibus/dev Add a sleep between every thread initialization and add indicator to graph title if the graph is up to date commit 76b65c1 Merge: 475a589 c76f7e7 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Wed May 19 19:23:53 2021 +0200 Merge pull request #142 from Crinibus/dev Add timeout to requests.get, simplify try except in method "Scraper.get_info" and format with Black commit 475a589 Merge: f92ad04 bee2bf4 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Wed May 12 18:27:32 2021 +0200 Merge pull request #141 from Crinibus/dev Update visualize.py commit f92ad04 Merge: 5d88402 fb1ba71 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Tue May 11 17:04:22 2021 +0200 Merge pull request #140 from Crinibus/dev Update README.md commit 5d88402 Merge: 13410d5 218c1bc Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Sat Apr 24 13:39:50 2021 +0200 Merge pull request #139 from Crinibus/dev Update methods Format.format_old_records_to_new Scraper.get_info and change some type hint in visualize.py commit 13410d5 Merge: 1d2f758 2a10e90 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Sat Apr 17 17:26:45 2021 +0200 Merge pull request #138 from Crinibus/dev Small change to README and add expect ValueError in method "Scraper.get_info" commit 1d2f758 Merge: f6e2ce8 d7cf4bc Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Sat Apr 17 00:35:40 2021 +0200 Merge pull request #137 from Crinibus/dev Format with Black and seperate visualize.py into more (generator) functions commit f6e2ce8 Merge: eeadc5d f353a13 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Thu Apr 15 20:37:14 2021 +0200 Merge pull request #136 from Crinibus/dev Slightly optimized visualize functions and fix problem with adding a product in method "Scraper.update_data" commit eeadc5d Merge: 16d194b 812ccda Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Tue Apr 13 19:56:27 2021 +0200 Merge pull request #135 from Crinibus/dev Fix problem with append datapoint with same date and price as latest datapoint commit 16d194b Merge: b307806 6072d11 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Tue Apr 13 19:10:41 2021 +0200 Merge pull request #134 from Crinibus/dev Version v1.1 commit b307806 Merge: 4119f55 19aa61f Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Sat Apr 10 00:24:53 2021 +0200 Merge pull request #133 from Crinibus/dev Fix README and add argument "--visualize-name" commit 4119f55 Merge: c0b7e9d afddf4a Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Apr 9 23:03:11 2021 +0200 Merge pull request #132 from Crinibus/dev Add support for adding multiple products at once commit c0b7e9d Merge: c452e57 5d4a8ae Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Apr 9 21:29:10 2021 +0200 Merge pull request #131 from Crinibus/dev Fix that product name in function "sharkgaming" was not in lowercase commit c452e57 Merge: e7d6186 69ba18a Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Apr 9 20:47:47 2021 +0200 Merge pull request #130 from Crinibus/dev Fix "pip" to "pip3" commit e7d6186 Merge: fc0d35a 110c560 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Apr 9 20:25:46 2021 +0200 Merge pull request #129 from Crinibus/dev Completely refactor code commit fc0d35a Merge: ecde2de 5112828 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Mar 5 00:03:51 2021 +0100 Merge pull request #128 from Crinibus/dev Update static method "change_name" in class "Format" commit ecde2de Merge: fdc8995 743d00b Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Thu Feb 4 19:18:53 2021 +0100 Merge pull request #127 from Crinibus/dev Dev to master commit fdc8995 Merge: 2971522 f075be0 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Dec 18 16:32:01 2020 +0100 Merge pull request #126 from Crinibus/dev Update README.md commit 2971522 Merge: 9feb921 712adb5 Author: Crinibus <57172157+Crinibus@users.noreply.github.com> Date: Fri Nov 27 16:13:39 2020 +0100 Merge pull request #125 from Crinibus/dev Update scraper.py in tech_scraper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.