Optimize scraping with threads #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o group products df by domains
Function "get_products_grouped_by_domain": - Create Scraper instances and group them in a dictionary where the key is the domain name and the value is Scraper instances that scrapes products from the domain name
Import functions: - start_threads_sequentially - get_products_df_grouped_by_domains - get_products_grouped_by_domain
- group products df by domain - create threads for the grouped products and group the threads by domain - make master threads to run scraper threads for each domain sequentially
…duct dataFrame to outside of function
Crinibus
deleted the
update-scrape-with-threads-group-products-df-by-domains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update so that scraping at different domains can happen at the same time, but scraping a each domain is sequentially
E.g. if there is four products to be scraped from two different domains, then one product from each domain is scraped at the same time, then after the request_delay the next product from each domain is being scraped at the same time.