Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception when url has no schema #199

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Raise exception when url has no schema #199

merged 4 commits into from
Nov 18, 2022

Conversation

Crinibus
Copy link
Owner

Add exception URLMissingSchema
Add constant URL_SCHEMES

Update add_product.py:

  • Add function is_missing_url_schema
  • Update function add_products to capture exception URLMissingSchema
  • Update function add_product to check if url has schema and raise exception URLMissingSchema if not

@Crinibus Crinibus marked this pull request as ready for review November 18, 2022 23:02
@Crinibus Crinibus merged commit fe12ce7 into master Nov 18, 2022
@Crinibus Crinibus deleted the error-when-url-is-missing-schema branch November 18, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Crinibus